linux-kernel - Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPcWJbibxahgnDAsnGbUpkurwSOtSsdV28hKbWxn_x83Jw@mail.gmail.com>
Date:   Mon, 24 Apr 2017 10:32:16 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>, arm@...nel.org,
        Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linaro-kernel@...ts.linaro.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-pm@...r.kernel.org, Rafael Wysocki <rjw@...ysocki.net>,
        Rob Herring <robh@...nel.org>,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries

On Mon, Apr 24, 2017 at 10:30 AM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> 2017-04-21 1:09 GMT+09:00 Krzysztof Kozlowski <krzk@...nel.org>:
>> On Thu, Apr 20, 2017 at 04:25:07PM +0530, Viresh Kumar wrote:
>>> Compiling the DT file with W=1, DTC warns like follows:
>>>
>>> Warning (unit_address_vs_reg): Node /opp_table0/opp@...0000000 has a
>>> unit name, but no reg property
>>>
>>> Fix this by replacing '@' with '-' as the OPP nodes will never have a
>>> "reg" property.
>>>
>>> Reported-by: Krzysztof Kozlowski <krzk@...nel.org>
>>> Reported-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>> Suggested-by: Mark Rutland <mark.rutland@....com>
>>> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
>>> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>>> Acked-by: Rob Herring <robh@...nel.org>
>>> ---
>>>  .../devicetree/bindings/devfreq/exynos-bus.txt     | 46 +++++++--------
>>>  arch/arm/boot/dts/exynos3250.dtsi                  | 46 +++++++--------
>>>  arch/arm/boot/dts/exynos4210.dtsi                  | 32 +++++------
>>>  arch/arm/boot/dts/exynos4412-prime.dtsi            |  4 +-
>>>  arch/arm/boot/dts/exynos4412.dtsi                  | 66 +++++++++++-----------
>>>  arch/arm/boot/dts/exynos5420.dtsi                  | 40 ++++++-------
>>>  arch/arm/boot/dts/exynos5800.dtsi                  | 56 +++++++++---------
>>>  arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi     | 48 ++++++++--------
>>>  arch/arm64/boot/dts/exynos/exynos5433.dtsi         | 50 ++++++++--------
>>>  9 files changed, 194 insertions(+), 194 deletions(-)
>>
>>
>> Thanks, split ARM64 from ARM and applied (for v4.12). arm-soc keeps DTS
>> separated between ARM architectures. Technically this should require a
>> resend but we had way too many resends for this simple patch.
>>
>
>
> Minor note:
>
> For arm64 part, Krzysztof's Signed-off-by is doubled.
> (commit 5dccc9873c4af60f4478b3ef54267353f25cc301)

Thanks for spotting it.

Best regards,
Krzysztof