linux-kernel - Re: [RFC PATCH] KASLR: mem_avoid_memmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170424090040.GC2310@x1>
Date:   Mon, 24 Apr 2017 17:00:40 +0800
From:   Baoquan He <bhe@...hat.com>
To:     kbuild test robot <lkp@...el.com>, fengguang.wu@...el.com
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        keescook@...omium.org, mingo@...nel.org, dave.jiang@...el.com,
        dan.j.williams@...el.com, hpa@...or.com, tglx@...utronix.de,
        dyoung@...hat.com, Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Yinghai Lu <yinghai@...nel.org>, Borislav Petkov <bp@...e.de>
Subject: Re: [RFC PATCH] KASLR: mem_avoid_memmap_index can be static

Hi Fengguang,

Thanks for pointing it out!

I am fine with defining mem_avoid_memmap_index it as static variable.
While Liyang suggested using a local static inside mem_avoid_memmap,
then mem_avoid_memmap_index is not needed any more. Do you think it's OK
to you?

Thanks
Baoquan

On 04/24/17 at 04:48pm, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>  kaslr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
> index 6649ecd..7190d35 100644
> --- a/arch/x86/boot/compressed/kaslr.c
> +++ b/arch/x86/boot/compressed/kaslr.c
> @@ -75,7 +75,7 @@ struct mem_vector {
>  #define MAX_MEMMAP_REGIONS	4
>  
>  static bool memmap_too_large;
> -int mem_avoid_memmap_index;
> +static int mem_avoid_memmap_index;
>  extern unsigned long get_cmd_line_ptr(void);
>  
>