linux-kernel - Re: [PATCH 1/1] staging: comedi: addi_apci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d20a03b-869a-ffe3-b3e2-28a3350398b8@mev.co.uk>
Date:   Mon, 24 Apr 2017 10:28:35 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Pan Bian <bianpan201602@....com>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Pan Bian <bianpan2016@....com>
Subject: Re: [PATCH 1/1] staging: comedi: addi_apci_3xxx: check return value

On 23/04/17 10:52, Pan Bian wrote:
> From: Pan Bian <bianpan2016@....com>
>
> Function pci_ioremap_bar() will return a NULL pointer if there is no
> enough memory. However, in function apci3xxx_auto_attach(), the return
> value of function pci_ioremap_bar() is not validated. This may result in
> NULL dereference in following access to dev->mmio. This patch fixes the
> bug.
>
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/staging/comedi/drivers/addi_apci_3xxx.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3xxx.c b/drivers/staging/comedi/drivers/addi_apci_3xxx.c
> index b6af3eb..a07d5bd 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3xxx.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3xxx.c
> @@ -787,6 +787,8 @@ static int apci3xxx_auto_attach(struct comedi_device *dev,
>
>  	dev->iobase = pci_resource_start(pcidev, 2);
>  	dev->mmio = pci_ioremap_bar(pcidev, 3);
> +	if (!dev->mmio)
> +		return -ENOMEM;
>
>  	if (pcidev->irq > 0) {
>  		ret = request_irq(pcidev->irq, apci3xxx_irq_handler,
>

Looks good. Thanks for the fix.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-