linux-kernel - Re: [PATCH] kallsyms: Use bounded strnchr() when parsing string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170424111200.8fe9ea1667b433709b265a1b@kernel.org>
Date:   Mon, 24 Apr 2017 11:12:00 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:     Jessica Yu <jeyu@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Michael Ellerman <mpe@...erman.id.au>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kallsyms: Use bounded strnchr() when parsing string

On Sun, 23 Apr 2017 22:53:43 +0530
"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com> wrote:

> When parsing for the <module:name> format, we use strchr() to look for
> the separator, when we know that the module name can't be longer than
> MODULE_NAME_LEN. Enforce the same using strnchr().

Looks good to me :)

Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks,

> 
> Signed-off-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
> ---
>  kernel/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 7eba6dea4f41..d3bd56ed3541 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -4017,7 +4017,7 @@ unsigned long module_kallsyms_lookup_name(const char *name)
>  
>  	/* Don't lock: we're in enough trouble already. */
>  	preempt_disable();
> -	if ((colon = strchr(name, ':')) != NULL) {
> +	if ((colon = strnchr(name, MODULE_NAME_LEN, ':')) != NULL) {
>  		if ((mod = find_module_all(name, colon - name, false)) != NULL)
>  			ret = mod_find_symname(mod, colon+1);
>  	} else {
> -- 
> 2.12.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>