linux-kernel - [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com>
Date:   Mon, 24 Apr 2017 12:01:06 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Kamil Debski <kamil@...as.org>
Cc:     Tomasz Figa <tomasz.figa@...il.com>, linux-pwm@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, b.zolnierkie@...sung.com
Subject: [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support

Hi,

This patchset fixes suspend/resume support in pwm-samsung
driver (which has an effect of fixing suspend/resume support
for PWM client drivers such as pwm-fan one). Then it removes
no longer needed suspend/resume code from pwm-fan driver.

It was tested on Odroid-XU3 board (with few extra patches
adding SoC/board suspend/resume support which are not in
upstream yet).

The initial issue that has been observed on this configuration
was that after suspend/resume operation the fan was turned on
(while the thermal code had explicitly disabled the fan by
calling back into pwm-fan driver before the suspend/resume).

Fixing this in the pwm-fan driver itself is not feasible since
pwm_config()/pwm_disable() & co. API saves information about
current state and doesn't pass the relevant values to PWM core
if they are identical to the ones used previously (moreover PWM
core itself does the same before calling into the PWM hardware
driver).

Changes since v1
(https://www.spinics.net/lists/kernel/msg2480445.html):
- added Acked-by from Guenter to patch #3
- fixed patch #2 to use the right variable (chip -> our_chip)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Bartlomiej Zolnierkiewicz (3):
  pwm: pwm-samsung: remove redundant checks from pwm_samsung_config()
  pwm: pwm-samsung: fix suspend/resume support
  hwmon: pwm-fan: remove no longer needed suspend/resume code

 drivers/hwmon/pwm-fan.c   | 32 ----------------------
 drivers/pwm/pwm-samsung.c | 70 +++++++++++++++++++++++------------------------
 2 files changed, 35 insertions(+), 67 deletions(-)

-- 
1.9.1