linux-kernel - Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170424104851.vuxrg2vuw5ltkp5n@dell>
Date:   Mon, 24 Apr 2017 11:48:51 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-gpio@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units

On Tue, 18 Apr 2017, Andy Shevchenko wrote:

> On Tue, 2017-04-11 at 14:54 +0100, Lee Jones wrote:
> > On Tue, 04 Apr 2017, Andy Shevchenko wrote:
> > 
> > > Crystal Cove and Whiskey Cove are two different PMICs which are
> > > installed on Intel Atom SoC based platforms.
> > > 
> > > Moreover there are two independent drivers that by some reason were
> > > supposed (*) to get into one kernel module.
> > > 
> > > Fix the mess by clarifying Kconfig option for Crystal Cove and split
> > > Whiskey Cove out of it.
> > > 
> > > (*) It looks like the configuration was never tested with
> > >     INTEL_SOC_PMIC=n. The line in Makefile is actually wrong.
> > > 
> > > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net> (supporter:ACPI)
> > > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> > > Acked-by: Zhang Rui <rui.zhang@...el.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > ---
> > >  - fix dependency for now, proper fix is to provide headers in
> > > platform_data/x86
> > >  - add tags
> > >  drivers/acpi/Kconfig         |  2 +-
> > >  drivers/gpio/Kconfig         |  2 +-
> > >  drivers/mfd/Kconfig          | 15 +++++++++++++--
> > >  drivers/mfd/Makefile         |  2 +-
> > >  drivers/platform/x86/Kconfig |  2 +-
> > >  drivers/thermal/Kconfig      |  2 +-
> > >  6 files changed, 18 insertions(+), 7 deletions(-)
> > 
> > Applied, thanks.
> 
> I didn't see it in next. Does it cause build issues still? I didn't get
> any report on it.

It's there now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog