linux-kernel - Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in arizona_extcon_get_micd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170424130039.GG1594@localhost.localdomain>
Date:   Mon, 24 Apr 2017 14:00:39 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
CC:     <patches@...nsource.wolfsonmicro.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        LKML <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in
 arizona_extcon_get_micd_configs()

On Mon, Apr 24, 2017 at 02:43:55PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 23 Apr 2017 22:44:19 +0200
> 
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "devm_kcalloc".
> 
> * Replace the specification of a data structure by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Actually fixes a bug on the alloc as well looks like the type was
wrong before.

Thanks,
Charles