lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170424133255.0a75cff1@canb.auug.org.au>
Date:   Mon, 24 Apr 2017 13:32:55 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: linux-next: build failure after merge of the tip tree

Hi all,

After merging the tip tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

kernel/tracepoint.c: In function 'tracepoint_remove_func':
kernel/tracepoint.c:253:4: error: implicit declaration of function 'static_key_slow_dec_cpuslocked' [-Werror=implicit-function-declaration]
    static_key_slow_dec_cpuslocked(&tp->key);
    ^

Caused by commit

  24db7a671bd5 ("trace/perf: Cure hotplug lock ordering issues")

static_key_slow_dec_cpuslocked() is only defined if HAVE_JUMP_LABEL is
set - which is only defined if defined(CC_HAVE_ASM_GOTO) &&
defined(CONFIG_JUMP_LABEL).  CONFIG_JUMP_LABEL is not set for this build.

I wasn't sure if just adding

  #define static_key_slow_dec_cpuslocked static_key_slow_dec

in the !HAVE_JUMP_LABEL case in include/linux/jump_label.h would be
sufficient, so I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ