[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdZHMWH2W-i4MGZ7NKzPHUURRmC-5YwiK7cVLCHKDsb7sw@mail.gmail.com>
Date: Mon, 24 Apr 2017 15:47:10 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Nandor Han <nandor.han@...com>
Cc: Greg KH <gregkh@...uxfoundation.org>,
"David S. Miller" <davem@...emloft.net>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Daniel Vetter <daniel.vetter@...ll.ch>,
Alexandre Courbot <gnurou@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Semi Malinen <semi.malinen@...com>
Subject: Re: [PATCH v2 2/4] gpio - Add EXAR XRA1403 SPI GPIO expander driver
On Thu, Apr 13, 2017 at 12:27 PM, Nandor Han <nandor.han@...com> wrote:
> This is a simple driver that provides a /sys/class/gpio
> interface for controlling and configuring the GPIO lines.
> It does not provide support for chip select or interrupts.
>
> Signed-off-by: Nandor Han <nandor.han@...com>
> Signed-off-by: Semi Malinen <semi.malinen@...com>
I almost want to make the driver depend on !GPIO_SYSFS because
of this commit message.
DO NOT USE OR ENCOURAGE THE USE OF THE GPIO SYSFS
INTERFACE.
Use the character device.
Use the example in tools/gpio/* as a guideline and testbed.
Use libgpiod as a rich userspace.
And the commit message should state that this is a driver
for such and such Exar hardware instead.
Thanks.
> +#include <linux/bitops.h>
> +#include <linux/gpio/driver.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/of_device.h>
> +#include <linux/of_gpio.h>
> +#include <linux/spi/spi.h>
> +#include <linux/regmap.h>
You are missing
#include <linux/seq_file.h>
and that is why the build robot is complaining.
Yours,
Linus Walleij
Powered by blists - more mailing lists