linux-kernel - Re: [PATCH] iio: st_pressure: st_accel: Initialise sensor platform data properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdawMT-_0q4apzm=cVEzexs=1wVpnq6bTewamAsu1EohCQ@mail.gmail.com>
Date:   Mon, 24 Apr 2017 16:26:48 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Shrirang Bagul <shrirang.bagul@...onical.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        Gregor Boirie <gregor.boirie@...rot.com>, rob@...nel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Marcin Niestroj <m.niestroj@...nn-global.com>
Subject: Re: [PATCH] iio: st_pressure: st_accel: Initialise sensor platform
 data properly

On Wed, Apr 19, 2017 at 4:05 PM, Shrirang Bagul
<shrirang.bagul@...onical.com> wrote:

> This patch fixes the sensor platform data initialisation for st_pressure
> and st_accel device drivers. Without this patch, the driver fails to
> register the sensors when the user removes and re-loads the driver.
>
> 1. Unload the kernel modules for st_pressure
> $ sudo rmmod st_pressure_i2c
> $ sudo rmmod st_pressure
>
> 2. Re-load the driver
> $ sudo insmod st_pressure
> $ sudo insmod st_pressure_i2c
> --- OR ---
> $ sudo modprobe st_pressure_i2c
>
> dmesg errors:
>
> [ 160.935707] iio iio:device2: DRDY on pdata not valid.
> [ 160.941505] st-press-i2c: probe of i2c-SMO9210:00 failed with error -22
>
> The driver fails to register the pressure sensor device. Devices
> supported by st_accel driver also suffer from the same bug.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@...onical.com>

Looks OK
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij