linux-kernel - Re: [PATCH] fsnotify: remove a stray unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170424144154.GD23988@quack2.suse.cz>
Date:   Mon, 24 Apr 2017 16:41:54 +0200
From:   Jan Kara <jack@...e.cz>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jan Kara <jack@...e.cz>, Miklos Szeredi <mszeredi@...hat.com>,
        Amir Goldstein <amir73il@...il.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] fsnotify: remove a stray unlock

On Fri 21-04-17 13:52:20, Dan Carpenter wrote:
> We recently shifted this code around, so we're no longer holding the
> lock on this path.
> 
> Fixes: 755b5bc681eb ("fsnotify: Remove indirection from mark list addition")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks! I've merged this patch.

								Honza
> 
> diff --git a/fs/notify/mark.c b/fs/notify/mark.c
> index 55955ded338d..9991f8826734 100644
> --- a/fs/notify/mark.c
> +++ b/fs/notify/mark.c
> @@ -603,7 +603,6 @@ int fsnotify_add_mark_locked(struct fsnotify_mark *mark, struct inode *inode,
>  			 FSNOTIFY_MARK_FLAG_ATTACHED);
>  	list_del_init(&mark->g_list);
>  	atomic_dec(&group->num_marks);
> -	spin_unlock(&mark->lock);
>  
>  	fsnotify_put_mark(mark);
>  	return ret;
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR