linux-kernel - Re: [PATCH v2 2/2] module: Add module name to modinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <065F583B-6150-45D6-A84B-757F63A6242E@jonmasters.org>
Date:   Tue, 25 Apr 2017 03:04:02 -0400
From:   Jon Masters <jcm@...masters.org>
To:     Kees Cook <keescook@...omium.org>, Jessica Yu <jeyu@...hat.com>
Cc:     Rusty Russell <rusty@...tcorp.com.au>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Heinrich Schuchardt <xypron.glpk@....de>,
        Nicholas Piggin <npiggin@...il.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        linux-kernel@...r.kernel.org,
        Lucas De Marchi <lucas.demarchi@...el.com>
Subject: Re: [PATCH v2 2/2] module: Add module name to modinfo

Nevermind. Missread the patch as doing something different on first pass.

-- 
Computer Architect | Sent from my 64-bit #ARM Powered phone

> On Apr 25, 2017, at 03:00, Jon Masters <jcm@...masters.org> wrote:
> 
>> On 04/21/2017 06:35 PM, Kees Cook wrote:
>> 
>> Accessing the mod structure (e.g. for mod->name) prior to having completed
>> check_modstruct_version() can result in writing garbage to the error logs
>> if the layout of the mod structure loaded from disk doesn't match the
>> running kernel's mod structure layout. This kind of mismatch will become
>> much more likely if a kernel is built with different randomization seed
>> for the struct layout randomization plugin.
>> 
>> Instead, add and use a new modinfo string for logging the module name.
> 
> +Lucas - probably something that the modinfo kmod utility should track.
> 
> Jon.
>