linux-kernel - Re: [PATCH] check for null while iterating over a scatterlist table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170425074217.GA22533@infradead.org>
Date:   Tue, 25 Apr 2017 00:42:17 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Rajnikant Bhojani <rajnikant.bhojani@...ridgetech.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] check for null while iterating over a scatterlist table

On Tue, Apr 25, 2017 at 01:08:49PM +0530, Rajnikant Bhojani wrote:
> during iterating over a scatterlist table also need to check for NULL
> along with number of scatterlist

Not sure this is a good idea.  Callers expect to iterate over the
full number in general.  Exiting early just papers over the bug
instead of fixing it.  A WARN_ON for this case might be a better idea.