linux-kernel - Re: [PATCH] phy: qcom-qmp: fix noderef.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5942f3d9-cd6b-d06c-c1f4-990566fb3a9d@codeaurora.org>
Date:   Tue, 25 Apr 2017 13:38:36 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        Stephen Boyd <sboyd@...eaurora.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: qcom-qmp: fix noderef.cocci warnings

Hi Kishon,


On 04/06/2017 09:28 PM, kbuild test robot wrote:
> drivers/phy/phy-qcom-qmp.c:847:37-43: ERROR: application of sizeof to pointer
>
>   sizeof when applied to a pointer typed expression gives the size of
>   the pointer
>
> Generated by: scripts/coccinelle/misc/noderef.cocci
>
> CC: Vivek Gautam <vivek.gautam@...eaurora.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---

Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

This patch got missed. Please consider pulling it in along with one more
patch [1] from Wei Yongjun.

[1] https://lkml.org/lkml/2017/4/24/1080

Best Regards
Vivek

>
>   phy-qcom-qmp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/phy/phy-qcom-qmp.c
> +++ b/drivers/phy/phy-qcom-qmp.c
> @@ -844,7 +844,7 @@ static int qcom_qmp_phy_vreg_init(struct
>   	int num = qmp->cfg->num_vregs;
>   	int i;
>   
> -	qmp->vregs = devm_kcalloc(dev, num, sizeof(qmp->vregs), GFP_KERNEL);
> +	qmp->vregs = devm_kcalloc(dev, num, sizeof(*qmp->vregs), GFP_KERNEL);
>   	if (!qmp->vregs)
>   		return -ENOMEM;
>   

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project