linux-kernel - Re: [PATCH] iio: adc: Add support for TI ADC1x8s102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2017 12:20:11 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:     Jan Kiszka <jan.kiszka@...mens.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] iio: adc: Add support for TI ADC1x8s102

On Tue, Apr 25, 2017 at 10:31 AM, Peter Meerwald-Stadler
<pmeerw@...erw.net> wrote:
>
>> This is an upstream port of an IIO driver for the TI ADC108S102 and
>> ADC128S102. The former can be found on the Intel Galileo Gen2 and the
>> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is
>> included.

> I think board-specific stuff should not go into the driver -> DT?

World is not ARM/DT only -> Unified Device Properties, yes.

P.S. I agree with everything else, though it looks a bit overlapping
with my review, which is a good sign to me :-)

-- 
With Best Regards,
Andy Shevchenko