linux-kernel - Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2017 15:27:34 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jérémy Lefaure <jeremy.lefaure@....epita.fr>
Cc:     Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

On Mon, Apr 24, 2017 at 6:31 PM, Jérémy Lefaure
<jeremy.lefaure@....epita.fr> wrote:
> On Mon, 24 Apr 2017 12:14:14 +0300
> Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>
>> On Sat, Apr 22, 2017 at 5:19 AM, Jérémy Lefaure
>> <jeremy.lefaure@....epita.fr> wrote:
>> > The cpufv sysfs file is defined as readable by anyone even if the
>> > attribute does not have a show function. The result of every read is an
>> > IO error. This file should be write only.
>>
>> Per se patch looks good to me, though would be better to add show()
>> hook as well?
>>
> It depends if we want to keep it write-only as it is documented in
> Documentation/ABI/testing/sysfs-platform-asus-wmi.
>
> If we want to have this file read/write, I can send a v2 of this patch.

I dunno we need.
So, since no answer from anyone I pushed this to testing, thanks!

-- 
With Best Regards,
Andy Shevchenko