linux-kernel - Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170425123250.ipltfpgcgbtk6h3g@mwanda>
Date:   Tue, 25 Apr 2017 15:32:50 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pavel Machek <pavel@....cz>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed
 memory allocation in ssi_add_controller()

1) That allocation will never fail in real life so it's dead code.
2) kmalloc and friends already have much better builtin in error
   messages so it's useless.
3) There is a small memory savings from removing it.

I'm not saying you should apply the patch, I'm just saying that these
messages are pointless and detrimental.

regards,
an carpenter