linux-kernel - Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79e166e2-ed4b-7386-c07f-b02d68f133b5@kaod.org>
Date:   Tue, 25 Apr 2017 16:28:52 +0200
From:   Cédric Le Goater <clg@...d.org>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linux-hwmon@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, svaidy@...ux.vnet.ibm.com,
        ego@...ux.vnet.ibm.com, akshay.adiga@...ux.vnet.ibm.com,
        andrew@...id.au
Subject: Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current
 sensors

On 04/22/2017 08:11 AM, Michael Ellerman wrote:
> Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com> writes:
>> On 04/21/2017 05:17 PM, Cédric Le Goater wrote:
>>> On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote:
>>>> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
>>>> index 6d2e660..1f329fa8 100644
>>>> --- a/drivers/hwmon/ibmpowernv.c
>>>> +++ b/drivers/hwmon/ibmpowernv.c
>>>> @@ -65,7 +66,8 @@ enum sensors {
>>>>  	{"fan", "ibm,opal-sensor-cooling-fan"},
>>>>  	{"temp", "ibm,opal-sensor-amb-temp"},
>>>>  	{"in", "ibm,opal-sensor-power-supply"},
>>>> -	{"power", "ibm,opal-sensor-power"}
>>>> +	{"power", "ibm,opal-sensor-power"},
>>>> +	{"curr"}, /* Follows newer device tree compatible ibm,opal-sensor */
>>>
>>> why isn't there a compatible string ? 
>>
>> Skiboot exports "ibm,opal-sensor" as compatible string for all the inband
>> sensors. Now if I define that as the compatible string here, then all the
>> sensors would get identified as "curr" type of sensor by the driver.
> 
> So fix it in skiboot?


After a memory refresh, this table is to maintain compatibility with 
the support of the FSP sensors in old firmware. These have peculiar
device node names and properties.  

So What the code is doing looks correct. But, you should also modify 
the 'enum sensors' to include a CURRENT value.

Thanks,

C.