linux-kernel - Re: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170425182549.GA18677@e104818-lin.cambridge.arm.com>
Date:   Tue, 25 Apr 2017 19:25:49 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        a.hajda@...sung.com, geert@...ux-m68k.org,
        Laura Abbott <labbott@...hat.com>, robin.murphy@....com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drivers: dma-mapping: Do not leave an invalid
 area->pages pointer in dma_common_contiguous_remap()

On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote:
> The dma_common_pages_remap() function allocates a vm_struct object and
> initialises the pages pointer to value passed as argument. However, when
> this function is called dma_common_contiguous_remap(), the pages array
> is only temporarily allocated, being freed shortly after
> dma_common_contiguous_remap() returns. Architecture code checking the
> validity of an area->pages pointer would incorrectly dereference already
> freed pointers. This has been exposed by the arm64 commit 44176bb38fa4
> ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU").
> 
> Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions")
> Cc: Laura Abbott <labbott@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reported-by: Andrzej Hajda <a.hajda@...sung.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>

Small correction on the subject, the prefix should be something like:

drivers: dma-mapping:

It's not an arm64 patch.

-- 
Catalin