linux-kernel - Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Apr 2017 21:10:19 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ilia Sergachev 
        <BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@...message.ch>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix few checkpatch warnings in
 ks_wlan_net.c

On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote:
> Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c

What type of warnings?  What checks?  It builds just fine for me here.

You need to be very specific.

And only do one type of thing per patch, a big "fixes all types of
warnings" is not ok in a single patch.

> 
> Signed-off-by: Ilia Sergachev <BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@...message.ch>
> Cc: devel@...verdev.osuosl.org,linux-kernel@...r.kernel.org

That last line doesn't make much sense, does it?

thanks,

greg k-h