lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Apr 2017 16:26:25 -0400 (EDT) From: David Miller <davem@...emloft.net> To: alexandre.belloni@...e-electrons.com Cc: al.kochet@...il.com, f.fainelli@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, sergei.shtylyov@...entembedded.com, rogerq@...com, madalin.bucur@....com Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> Date: Tue, 25 Apr 2017 22:09:11 +0200 > Hi, > > On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: >> Hello David! >> >> > 25 апр. 2017 г., в 17:36, David Miller <davem@...emloft.net> написал(а): >> > >> > So... what are we doing here? >> > >> > My understanding is that this should fix the same problem that commit >> > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto >> > negotiation on startup") fixed and that this micrel commit should thus >> > be reverted to improve MAC startup times which regressed. >> > >> > Florian, any guidance? >> >> Yes, this should be done. >> >> I aksed Alexandre to check if 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto >> negotiation on startup») can be reverted, and he answered what it may do that >> sometime this/next week. >> > > Yes, it can be safely reverted after Alexander's patch. I had to test on > v4.7 because we are not using interrupts on those boards since v4.8 > (another issue to be fixed). > > As Florian pointed out, at the time I sent my patch, I didn't have time > to investigate whether this was affecting other phys, see > https://lkml.org/lkml/2016/2/26/766 > > I can send the revert or you can do it. I can take care of it, thanks for testing.
Powered by blists - more mailing lists