linux-kernel - Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcB-Wpjz9JEh1iJBGuVX-sc=KLp_CQqbX8JyxFAVqga+A@mail.gmail.com>
Date:   Wed, 26 Apr 2017 01:04:05 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jérémy Lefaure <jeremy.lefaure@....epita.fr>
Cc:     David Howells <dhowells@...hat.com>, linux-cachefs@...hat.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

On Wed, Apr 26, 2017 at 12:37 AM, Jérémy Lefaure
<jeremy.lefaure@....epita.fr> wrote:
> On Tue, 25 Apr 2017 00:47:41 +0300
> Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> Ok I get it. But changing the format can break the userland tool
> anyway, can't it ? For example if a userland tool expects the value 75,
> it won't read it properpy in BCD.

Maybe.

>> So, if it's okay in this, perhaps paragraph explaining side effects in
>> commit message would be good to have/
>>
> Maybe the best fix would be to increase the size of the _type buffer to
> 4 so the unsigned byte can fit in it. And change the documentation to
> decimal value. What do you think about this solution ?

Yes, it would work.

-- 
With Best Regards,
Andy Shevchenko