lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Apr 2017 15:31:48 +0800 From: Dave Young <dyoung@...hat.com> To: Ingo Molnar <mingo@...nel.org> Cc: Yinghai Lu <yinghai@...nel.org>, Simon Horman <horms@...ge.net.au>, kexec@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] memmap: Parse "Reserved" together with "reserved" On 04/26/17 at 03:28pm, Dave Young wrote: > On 04/26/17 at 08:22am, Ingo Molnar wrote: > > > > * Yinghai Lu <yinghai@...nel.org> wrote: > > > > > For x86 with recent kernel after > > > commit 640e1b38b0 ("x86/boot/e820: Basic cleanup of e820.c") > > > change "reserved" to "Reserved" in /sys firmware memmap and /proc/iomem. > > > > > > So here, we add handling for that too. > > > > > > Signed-off-by: Yinghai Lu <yinghai@...nel.org> > > > > > > --- > > > kexec/arch/i386/crashdump-x86.c | 2 ++ > > > kexec/arch/ia64/kexec-ia64.c | 2 ++ > > > kexec/arch/mips/kexec-mips.c | 2 ++ > > > kexec/firmware_memmap.c | 2 ++ > > > 4 files changed, 8 insertions(+) > > > > I'd rather fix the bug I introduced and undo the reserved->Reserved string change > > This patch parses both 'reserved' and 'Reserved' it should be fine, but > reverting the change in kernel sounds better.. Hmm, after press sending I noticed old kexec-tools with new kernel, it is still a problem, so we'd better to revert the kernel changes. > > > in e820.c: I didn't realize that it's exposed in sysfs and had quasi-ABI > > consequences for kexec. > > > > Agreed? > > > > Thanks, > > > > Ingo > > > > _______________________________________________ > > kexec mailing list > > kexec@...ts.infradead.org > > http://lists.infradead.org/mailman/listinfo/kexec > > Thanks > Dave
Powered by blists - more mailing lists