linux-kernel - Re: [PATCH] fs:affs:fix sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170426074620.GC21218@quack2.suse.cz>
Date:   Wed, 26 Apr 2017 09:46:20 +0200
From:   Jan Kara <jack@...e.cz>
To:     Heloise <os@...as.ac.cn>
Cc:     akpm@...ux-foundation.org, fabf@...net.be, viro@...iv.linux.org.uk,
        jack@...e.cz, mszeredi@...hat.com, mikulas@...bright.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs:affs:fix sb_bread() return value

On Tue 25-04-17 23:59:14, Heloise wrote:
> When the function sb_bread() fails, the return value should
> be -EIO, fix it.
> 
> Signed-off-by: Heloise <os@...as.ac.cn>

Well, in the mount(2) manpage we have:

EINVAL source had an invalid superblock. Or, a remount (MS_REMOUNT) was
attempted, but source was not already mounted on target. Or, a move
(MS_MOVE) was attempted, but source was not a mount point, or was '/'.

And EIO is not documented as possible error for mount(2). Looking at e.g.
ext4 it also returns EINVAL when superblock cannot be read so I guess it is
an expected return value in this case.

								Honza

> ---
>  fs/affs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/affs/super.c b/fs/affs/super.c
> index c2c27a8..df1f4fe 100644
> --- a/fs/affs/super.c
> +++ b/fs/affs/super.c
> @@ -419,7 +419,7 @@ static int affs_fill_super(struct super_block *sb, void *data, int silent)
>  	boot_bh = sb_bread(sb, 0);
>  	if (!boot_bh) {
>  		pr_err("Cannot read boot block\n");
> -		return -EINVAL;
> +		return -EIO;
>  	}
>  	memcpy(sig, boot_bh->b_data, 4);
>  	brelse(boot_bh);
> -- 
> 2.1.0
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR