linux-kernel - Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170426092913.GA21563@kroah.com>
Date:   Wed, 26 Apr 2017 11:29:13 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Maksim Salau <maksim.salau@...il.com>
Cc:     Juergen Stuber <starblue@...rs.sourceforge.net>,
        legousb-devel@...ts.sourceforge.net, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alfredo Rafael Vicente Boix <alviboi@...il.com>
Subject: Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack

On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote:
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().
> 
> Signed-off-by: Maksim Salau <maksim.salau@...il.com>
> Tested-by: Alfredo Rafael Vicente Boix <alviboi@...il.com>;
> Cc: stable <stable@...r.kernel.org>
> 
> ---
>   Changes in v3:
>    * rebased against usb-next;
>    * removed Tested-by: Alfredo Rafael Vicente Boix <alviboi@...il.com>;

I added this back, as it matters, and your change from the previous
version was trivial.

>    * removed Cc: stable@...r.kernel.org
>      since this patch doesn't apply against v4.10.12

I added this back as well :)

thanks,

greg k-h