linux-kernel - Re: [PATCH] x86: convert threshold_bank.cpus from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170426101819.fswayow3ga7hnxsb@pd.tnic>
Date:   Wed, 26 Apr 2017 12:18:19 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Elena Reshetova <elena.reshetova@...el.com>
Cc:     linux-kernel@...r.kernel.org, dwindsor@...il.com,
        ishkamiel@...il.com, keescook@...omium.org
Subject: Re: [PATCH] x86: convert threshold_bank.cpus from atomic_t to
 refcount_t

On Thu, Apr 20, 2017 at 04:38:56PM +0300, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
> 
> Suggested-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Elena Reshetova <elena.reshetova@...el.com>
> Reviewed-by: Hans Liljestrand <ishkamiel@...il.com>
> Reviewed-by: David Windsor <dwindsor@...il.com>
> ---
>  arch/x86/include/asm/amd_nb.h        | 3 ++-
>  arch/x86/kernel/cpu/mcheck/mce_amd.c | 6 +++---
>  2 files changed, 5 insertions(+), 4 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.