linux-kernel - Re: [PATCH v2] Staging: ks7010: style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170426104555.6k5st7izvhapqxhg@mwanda>
Date:   Wed, 26 Apr 2017 13:45:55 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Ilia Sergachev <ilia.sergachev@...bas.ch>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: ks7010: style fix

On Wed, Apr 26, 2017 at 08:37:56PM +1000, Tobin C. Harding wrote:
> On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote:
> > Fix the style of block comments.
> > Move trailing */ to a separate line.
> > Checkpatch was showing:
> > WARNING: Block comments use a trailing */ on a separate line.
> 
> You are doing well Ilia. A few nitpicks
> 
> - Your first subject was better (excluding the filname) :) it was more
>   descriptive.

Yeah.   This subject is bad.

> 
> - staging has a small 's'. You can verify with;
>   $ git log --pretty=oneline drivers/staging/ks7010/ks_wlan_net.c 

Nah..  It can go either way.  No one cares.

regards,
dan carpenter