linux-kernel - Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13744.1493204125@warthog.procyon.org.uk>
Date:   Wed, 26 Apr 2017 11:55:25 +0100
From:   David Howells <dhowells@...hat.com>
To:     "Dmitry V. Levin" <ldv@...linux.org>
Cc:     dhowells@...hat.com, Al Viro <viro@...iv.linux.org.uk>,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
        mtk.manpages@...il.com
Subject: Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative

Dmitry V. Levin <ldv@...linux.org> wrote:

> remove false assertion

It's not a false assertion.  I defined the statx interface that way.

> The best fix for this source of confusion is to change the type
> of struct statx_timestamp.tv_nsec from __s32 to __u32 .

Okay, if we're going to do the comment change, we should effect the type
change also.  Do you want to update your patch?

David