linux-kernel - [PATCH] gpio: f7188x: add missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2017 16:05:39 +0100
From:   Colin King <colin.king@...onical.com>
To:     Marty Plummer <netz.kernel@...il.com>,
        Alexandre Courbot <gnurou@...il.com>,
        linux-gpio@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] gpio: f7188x: add missing break in switch statement

From: Colin Ian King <colin.king@...onical.com>

The case statement for f71889a is missing a break statement, add it.

Detected with CoverityScan, CID#1431861 ("Missig break in switch")

Fixes: d69843e416d31 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/gpio/gpio-f7188x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index c013ff5deb70..13350c9d7f5e 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -398,6 +398,7 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
 	case f71889a:
 		data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank);
 		data->bank = f71889a_gpio_bank;
+		break;
 	case f71889f:
 		data->nr_bank = ARRAY_SIZE(f71889_gpio_bank);
 		data->bank = f71889_gpio_bank;
-- 
2.11.0