linux-kernel - Re: [PATCH] iommu: Print a message with the default domain type created

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170426155044.GA1332@8bytes.org>
Date:   Wed, 26 Apr 2017 17:50:44 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Robert Richter <rrichter@...ium.com>
Cc:     Will Deacon <will.deacon@....com>,
        linux-arm-kernel@...ts.infradead.org,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: Print a message with the default domain type
 created

Hi Robert,

On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote:
> -	pr_info("Adding device %s to group %d\n", dev_name(dev), group->id);
> +	pr_info("Adding device %s to group %d, default domain type %d\n",
> +		dev_name(dev), group->id,
> +		group->default_domain ? group->default_domain->type : -1);

Printing just a number is not very user-friendly. We have only two
default domain-types right now, so it is sufficient to just print
additional information if a device is identity-mapped. Something like

	"Adding device %s to group %d - using identity mapping"


Regards,

	Joerg