linux-kernel - Re: [PATCH] scsi: stex: make S6flag static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05e23578-0bc9-ebcc-28cd-22b8e6a06f00@gmail.com>
Date:   Wed, 26 Apr 2017 10:40:52 +0800
From:   Charles Chiou <ch1102chiou@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Charles <charles.chiou@...promise.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Promise_Linux@...mise.com
Subject: Re: [PATCH] scsi: stex: make S6flag static

Looks good to me.
Thanks for the improvement.

On 4/26/2017 1:36 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> This module specific flag can be made static as it does
> not need to be in global scope.
> 
 > Reviewed-by: Charles Chiou <charles.chiou@...promise.com>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/scsi/stex.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 0751561b59da..9b20643ab49d 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -363,7 +363,7 @@ struct st_card_info {
>   	u16 sts_count;
>   };
>   
> -int S6flag;
> +static int S6flag;
>   static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
>   static struct notifier_block stex_notifier = {
>   	stex_halt, NULL, 0
>