linux-kernel - Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170426031211.GB18468@eros>
Date:   Wed, 26 Apr 2017 13:12:11 +1000
From:   "Tobin C. Harding" <me@...in.cc>
To:     Ilia Sergachev <ilia.sergachev@...bas.ch>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c

On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote:
> This is a patch to the ks_wlan_net.c file that fixes up the following warning
> found by the checkpatch.pl tool:
> WARNING: Block comments use a trailing */ on a separate line

Good work resubmitting this following Greg's comments. May I suggest
some ways to hasten your success.

Note firstly, that I appreciate that writing the gitlog message is
very difficult to do well. I am by no means an expert.

 - You don't need to mention the file, especially not in the subject. We
   can see the files changed from the patch itself.
 - You should refrain from using 'this patch', the subject (as in
   subject, object, verb) is implicit.

See Documentation/process/submitting-patches.rst (Section 2: Describe
your changes). 

Example

Checkpatch emits WARNING: Block comments use a trailing */ on a
separate line.

Move trailing */ to separate line.

Good luck,
Tobin.