linux-kernel - Re: [PATCH v4] Staging: most: use __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1704261424060.22604@panther>
Date:   Wed, 26 Apr 2017 14:24:32 -0700 (PDT)
From:   Chandra Annamaneni <chandra627@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
cc:     Chandra Annamaneni <chandra627@...il.com>,
        christian.gromm@...rochip.com, andrey.shvetsov@....de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] Staging: most: use __func__ instead of the function
 name

Sorry!
And thanks for pointing it out.

regards
Chandra

On Wed, 26 Apr 2017, Dan Carpenter wrote:

> On Wed, Apr 26, 2017 at 06:02:29AM -0700, Chandra Annamaneni wrote:
> > 
> > Change video.c to use %s, __func__ instead of function names.
> > Warnings flagged by checkpatch.pl
> > 
> > Signed-off-by: Chandra Annamaneni <chandra627@...il.com>
> > 
> > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c
> > index 59e861e..e074841 100644
> > --- a/drivers/staging/most/aim-v4l2/video.c
> > +++ b/drivers/staging/most/aim-v4l2/video.c
> > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> >  	struct most_video_dev *mdev = video_drvdata(filp);
> >  	struct aim_fh *fh;
> > 
> > -	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> > +	v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> 
> You sent the reversed patch.
> 
> regards,
> dan carpenter
> 
>