linux-kernel - Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58FFE592.2030203@gmail.com>
Date:   Tue, 25 Apr 2017 17:10:58 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <stephen.boyd@...aro.org>,
        Michal Marek <mmarek@...e.com>, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays

On 04/25/17 15:04, Masahiro Yamada wrote:
> 2017-04-25 8:05 GMT+09:00  <frowand.list@...il.com>:
>> From: Frank Rowand <frank.rowand@...y.com>
>>
>> The dtc compiler version that adds initial support was available
>> in 4.11-rc1.  Add the ability to set the dtc compiler flags needed
>> by overlays.
>>
>> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
>> ---
> 
> 
> I know your motivation for 1/2 is overlay,
> but this patch itself is more generic.
> (support for per-file dtc compiler flag)
> 
> Could you reword the commit subject a little bit?
> 
> Otherwise,
> 
> Acked-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Fixed in version 4.

-Frank

> 
> 
> 
>>  scripts/Makefile.lib | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 0a07f9014944..0bbec480d323 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -283,6 +283,8 @@ ifeq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
>>  DTC_FLAGS += -Wno-unit_address_vs_reg
>>  endif
>>
>> +DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
>> +
>>  # Generate an assembly file to wrap the output of the device tree compiler
>>  quiet_cmd_dt_S_dtb= DTB     $@
>>  cmd_dt_S_dtb=                                          \
>> --
> 
>