linux-kernel - Re: [PATCH v2] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4i_mRLSxm7YAnk_p8PhP=kyhT1aZZcrG-zZxXXWhGQuew@mail.gmail.com>
Date:   Wed, 26 Apr 2017 15:37:42 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Rafael Wysocki <rafael.j.wysocki@...el.com>,
        Anush Seetharaman <anush.seetharaman@...el.com>,
        Tiffany Kasanicky <tiffany.j.kasanicky@...el.com>,
        Ryon Jensen <ryon.jensen@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stable <stable@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Kristin Jacque <kristin.jacque@...el.com>,
        Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH v2] acpi: fix acpi_get_table() leak / acpi-sysfs denial of service

On Wed, Apr 26, 2017 at 3:25 PM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> On Tue, Apr 25, 2017 at 9:58 PM, Dan Williams <dan.j.williams@...el.com> wrote:
>> Reading an ACPI table through the /sys/firmware/acpi/tables interface
>> more than 65,536 times leads to the following log message:
>>
>>  ACPI Error: Table ffff88033595eaa8, Validation count is zero after increment
>>   (20170119/tbutils-423)
>>
>> ...and the table being unavailable until the next reboot. Add the
>> missing acpi_put_table() so the table ->validation_count is decremented
>> after each read.
>>
>> Cc: <stable@...r.kernel.org>
>> Cc: Zhang Rui <rui.zhang@...el.com>
>> Cc: Rafael Wysocki <rafael.j.wysocki@...el.com>
>> Cc: Kristin Jacque <kristin.jacque@...el.com>
>> Cc: Tiffany Kasanicky <tiffany.j.kasanicky@...el.com>
>> Cc: Ryon Jensen <ryon.jensen@...el.com>
>> Reported-by: Anush Seetharaman <anush.seetharaman@...el.com>
>> Fixes: 1c8fce27e275 ("ACPI: introduce drivers/acpi/sysfs.c")
>> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>
> I'm going to apply this, but your Fixes tag is not correct.
>
> validation_count was added to struct acpi_table_desc by commit
>
> commit 174cc7187e6f088942c8e74daa7baff7b44b33c9
> Author: Lv Zheng <lv.zheng@...el.com>
> Date:   Wed Dec 14 15:04:25 2016 +0800
>
>     ACPICA: Tables: Back port acpi_get_table_with_size() and
> early_acpi_os_unmap_memory()
> from Linux kernel
>
> from the 4.10 time frame, so IMO it should be
>
> Fixes: 174cc7187e6f (ACPICA: Tables: Back port
> acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux
> kernel)
>

Ah, thanks for the catch, I missed that detail and was wrong to argue
it was a 7 year old bug. Apologies Lv!