linux-kernel - Re: [PATCH v2 0/2] module: Add module name to modinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLbNNon9QAE4qsf1=GP47BDOVJ2KbeuLh1WC98KCCHzQQ@mail.gmail.com>
Date:   Tue, 25 Apr 2017 21:43:49 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jessica Yu <jeyu@...hat.com>
Cc:     Rusty Russell <rusty@...tcorp.com.au>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Heinrich Schuchardt <xypron.glpk@....de>,
        Nicholas Piggin <npiggin@...il.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] module: Add module name to modinfo

On Tue, Apr 25, 2017 at 7:32 PM, Jessica Yu <jeyu@...hat.com> wrote:
> +++ Kees Cook [21/04/17 15:35 -0700]:
>
>> The mod structure is accessed for the "name" field prior to validating
>> sanity in check_modstruct_version(). This becomes very obvious once
>> struct layout randomization is happening, so instead add the module
>> name to modinfo and use that until the mod struct has been sanity-checked.
>>
>> -Kees
>>
>> v2:
>> - adjusted for more odd name load failure cases; jeyu
>
>
> Hi Kees!
>
> These patches look fine to me, would you mind if I held on to them
> until after the upcoming merge window? (Since we're at -rc8, and I'd
> still like for them to sit in -next for a while)

Sure thing; I'm in no rush. :)

Thanks!

-Kees

-- 
Kees Cook
Pixel Security