linux-kernel - Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7732b5a1-965d-7056-f4ef-ff4b58ae15f7@sakamocchi.jp>
Date:   Thu, 27 Apr 2017 20:13:04 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Arnd Bergmann <arnd@...db.de>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     alsa-devel@...a-project.org, Vinod Koul <vinod.koul@...el.com>,
        Jayachandran B <jayachandran.b@...el.com>,
        linux-kernel@...r.kernel.org, Ramesh Babu <ramesh.babu@...el.com>,
        G Kranthi <gudishax.kranthikumar@...el.com>,
        Senthilnathan Veppur <senthilnathanx.veppur@...el.com>,
        Jeeja KP <jeeja.kp@...el.com>,
        "Subhransu S. Prusty" <subhransu.s.prusty@...el.com>
Subject: Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use

On Apr 27 2017 19:59, Arnd Bergmann wrote:
> The error handling in bxt_sst_dsp_init() got changed in a way that
> it now derefences an uninitialized pointer when printing a warning
> about the device not being found:
>
> sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
> sound/soc/intel/skylake/bxt-sst.c:567:14: error: 'skl' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> As we do have a valid device pointer available at the call site,
> let's use that instead.
>
> Fixes: 9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  sound/soc/intel/skylake/bxt-sst.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

> diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c
> index fde4bc0f35b0..f5e7dbb1ba39 100644
> --- a/sound/soc/intel/skylake/bxt-sst.c
> +++ b/sound/soc/intel/skylake/bxt-sst.c
> @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
>
>  	ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev);
>  	if (ret < 0) {
> -		dev_err(skl->dev, "%s: no device\n", __func__);
> +		dev_err(dev, "%s: no device\n", __func__);
>  		return ret;
>  	}

Regards

Takashi Sakamoto