lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Apr 2017 11:03:31 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Michal Hocko <mhocko@...nel.org> Cc: linux-arm-kernel@...ts.infradead.org, Russell King <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>, zijun_hu <zijun_hu@....com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Chris Wilson <chris@...is-wilson.co.uk>, open list <linux-kernel@...r.kernel.org>, "open list:MEMORY MANAGEMENT" <linux-mm@...ck.org>, angus@...usclark.org Subject: Re: [PATCH v2 1/3] mm: Silence vmap() allocation failures based on caller gfp_flags On 04/27/2017 10:56 AM, Michal Hocko wrote: > On Thu 27-04-17 10:38:58, Florian Fainelli wrote: >> If the caller has set __GFP_NOWARN don't print the following message: >> vmap allocation for size 15736832 failed: use vmalloc=<size> to increase >> size. >> >> This can happen with the ARM/Linux or ARM64/Linux module loader built >> with CONFIG_ARM{,64}_MODULE_PLTS=y which does a first attempt at loading >> a large module from module space, then falls back to vmalloc space. >> >> Signed-off-by: Florian Fainelli <f.fainelli@...il.com> > > Acked-by: Michal Hocko <mhocko@...e.com> > > just a nit > >> --- >> mm/vmalloc.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index 0b057628a7ba..d8a851634674 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -521,9 +521,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, >> } >> } >> >> + if (gfp_mask & __GFP_NOWARN) >> + goto out; >> + >> if (printk_ratelimit()) > > if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit()) >> pr_warn("vmap allocation for size %lu failed: use vmalloc=<size> to increase size\n", >> size); > > would be shorter and you wouldn't need the goto and a label. Do you want me to resubmit with that change included? -- Florian
Powered by blists - more mailing lists