linux-kernel - Re: [PATCH] Enabled pstore write for powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 06:21:26 +1000
From:   Anton Blanchard <anton@...ba.org>
To:     Ankit Kumar <ankit@...ux.vnet.ibm.com>
Cc:     keescook@...omium.org, anton@...msg.org, ccross@...roid.com,
        tony.luck@...el.com, xinhui.pan@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org, mahesh@...ux.vnet.ibm.com,
        geliangtang@....com, paulus@...ba.org,
        andrew.donnellan@....ibm.com, linuxppc-dev@...ts.ozlabs.org,
        dja@...ens.net
Subject: Re: [PATCH] Enabled pstore write for powerpc

Hi Ankit,

> After commit c950fd6f201a kernel registers pstore write based on flag
> set. Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG)
> is not set for powerpc architecture. On panic, kernel doesn't write
> message to /fs/pstore/dmesg*(Entry doesn't gets created at all).
> 
> This patch enables pstore write for powerpc architecture by setting
> PSTORE_FLAGS_DMESG flag.
> 
> Fixes:c950fd6f201a pstore: Split pstore fragile flags

Ouch! We've used pstore to shoot customer bugs, so we should also mark
this for stable. Looks like 4.9 onwards?

Anton

> Signed-off-by: Ankit Kumar <ankit@...ux.vnet.ibm.com>
> ---
> 
>  arch/powerpc/kernel/nvram_64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kernel/nvram_64.c
> b/arch/powerpc/kernel/nvram_64.c index d5e2b83..021db31 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum
> pstore_type_id *type, static struct pstore_info nvram_pstore_info = {
>  	.owner = THIS_MODULE,
>  	.name = "nvram",
> +	.flags = PSTORE_FLAGS_DMESG,
>  	.open = nvram_pstore_open,
>  	.read = nvram_pstore_read,
>  	.write = nvram_pstore_write,