linux-kernel - Re: [PATCH] iio: adc: Add support for TI ADC1x8s102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a210132-854b-cf3e-da33-fc3d073ad491@kernel.org>
Date:   Thu, 27 Apr 2017 07:01:07 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] iio: adc: Add support for TI ADC1x8s102

On 26/04/17 10:01, Mika Westerberg wrote:
> On Tue, Apr 25, 2017 at 06:12:12PM +0200, Jan Kiszka wrote:
>> Now, do you also a suggestion where to put that 5 V reference voltage
>> value that is hard-coded (via wiring) on the target boards for the ADC?
>> That is now device-specific, not a controller parameter. Is there an
>> ACPI-way to express such a parameter?
> 
> You may put it into device property using _DSD (as long as you don't try
> to represent regulators or so).
> 
>> How would that be done for DTs?
> 
> I don't know but you may look under Documentation/devicetree/bindings if
> there is anything.
Under DT it would be done using a fixed voltage regulator.
> 
>> Plan B would be hard-coding in the code for now, waiting for a second,
>> non-ACPI user to address it.
> 
> Sounds reasonable.
Somewhat of a pain to basically use a random value as the default going
forward.  Presumably this isn't the first ever ACPI table to need to
tell use about a reference voltage...

Mark, seen anything similar?

I see https://www.kernel.org/doc/Documentation/arm64/arm-acpi.txt suggests
that mapping to regulators isn't expected to ever happen...

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>