linux-kernel - Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae39b3ba-bfeb-9507-2323-991eea2d09f3@lwfinger.net>
Date:   Thu, 27 Apr 2017 19:20:58 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Justin Vreeland <justin@...eeland.com>, gregkh@...uxfoundation.org,
        hadess@...ess.net
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should
 be enclosed in parentheses

On 04/27/2017 07:09 PM, Justin Vreeland wrote:
> Signed-off-by: Justin Vreeland <justin@...eeland.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..13c4aebd178e 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,7 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
>  #define AVG_THERMAL_NUM		8
>  #define IQK_Matrix_REG_NUM	8
> -#define IQK_Matrix_Settings_NUM	14+24+21 /*  Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM	(14+24+21) /*  Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */

You should also put spaces around the plus signs, and fix the lines with more 
then 80 columns.

The comment about non-blank commit messages also applies.

Larry

>
>  #define		DM_Type_ByFW			0
>  #define		DM_Type_ByDriver		1
>