linux-kernel - Re: [PATCH] staging: speakup: fix wrong code indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170428071146.GA27730@kroah.com>
Date:   Fri, 28 Apr 2017 09:11:46 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Michael Mera <dev@...haelmera.com>
Cc:     William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: fix wrong code indent

On Fri, Apr 28, 2017 at 03:20:24PM +0900, Michael Mera wrote:
> Remove unecessary multiline comment, fixes checkpatch messages:
> ERROR: code indent should use tabs where possible
> WARNING: Block comments should align the * on each line
> 
> Signed-off-by: Michael Mera <dev@...haelmera.com>
> ---
>  drivers/staging/speakup/speakup_decpc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 6bf38e49a96d..94ca6987f71b 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -84,9 +84,7 @@
>  #define	CTRL_last_index		0x0b00	/*   get last index spoken */
>  #define	CTRL_io_priority	0x0c00	/*   change i/o priority */
>  #define	CTRL_free_mem		0x0d00	/*   get free paragraphs on module */
> -#define	CTRL_get_lang		0x0e00	/* return bit mask of loaded
> -					         * languages
> -					         */
> +#define	CTRL_get_lang		0x0e00	/* return bitmask of loaded languages */

And now you have a different coding style warning :(

Sorry, you can't replace one for another.

greg k-h