linux-kernel - Re: [PATCH] pstore: Solve lockdep warning by moving inode locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170428075233.GI3390@nuc-i3427.alporthouse.com>
Date:   Fri, 28 Apr 2017 08:52:33 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Marta Lofstedt <marta.lofstedt@...el.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] pstore: Solve lockdep warning by moving inode locks

On Thu, Apr 27, 2017 at 04:20:37PM -0700, Kees Cook wrote:
> Lockdep complains about a possible deadlock between mount and unlink
> (which is technically impossible), but fixing this improves possible
> future multiple-backend support, and keeps locking in the right order.

I have merged your for-next/pstore branch (which included this patch,
so I hope I chose correctly ;) into our CI. That should exercise it on
the machines that we originally found the lockdep splat.

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre