linux-kernel - Re: [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170428090808.GA84977@localhost>
Date:   Fri, 28 Apr 2017 09:08:08 +0000
From:   Jayachandran C <jnair@...iumnetworks.com>
To:     Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Will.Deacon@....com, catalin.marinas@....com, mark.rutland@....com,
        acme@...nel.org, alexander.shishkin@...ux.intel.com,
        peterz@...radead.org, mingo@...hat.com, gpkulkarni@...il.com
Subject: Re: [PATCH v2 1/4] perf utils: passing pmu as a parameter to
 function get_cpuid_str

On Fri, Apr 28, 2017 at 10:23:44AM +0530, Ganapatrao Kulkarni wrote:
> cpuid string will not be same on all CPUs on heterogeneous
> platforms like ARM's big.LITTLE, adding provision(using pmu->cpus)
> to find cpuid string from associated CPUs of PMU CORE device.
> 
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
> ---
>  tools/perf/arch/powerpc/util/header.c |  3 ++-
>  tools/perf/arch/x86/util/header.c     |  4 +++-
>  tools/perf/util/header.h              |  3 ++-
>  tools/perf/util/pmu.c                 | 10 ++++++----
>  4 files changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
> index 9aaa6f5..9a70cc1 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
> @@ -34,10 +34,11 @@
>  }
>  
>  char *
> -get_cpuid_str(void)
> +get_cpuid_str(struct perf_pmu *pmu)
>  {
>  	char *bufp;
>  
> +	do { if (pmu) {} } while (0);

If this is to avoid warnings, can you use __maybe_unused here?

JC.