linux-kernel - Re: [PATCH v2] staging: speakup: fix wrong code indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bmrgj3rr.fsf@michaelmera.com>
Date:   Fri, 28 Apr 2017 18:11:04 +0900
From:   Michael Mera <dev@...haelmera.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-kernel@...r.kernel.org, Michael Mera <dev@...haelmera.com>
Subject: Re: [PATCH v2] staging: speakup: fix wrong code indent

Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:

> On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
>> Remove unnecessary multiline comment, fixes checkpatch messages:
>> ERROR: code indent should use tabs where possible
>> WARNING: Block comments should align the * on each line
>> 
>> Signed-off-by: Michael Mera <dev@...haelmera.com>
>> ---
>>  drivers/staging/speakup/speakup_decpc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> What changed from v1?  That needs to go below the --- line.

Oh. Sorry. I fixed the spelling of the patch message, since I
though that was the problem you detected but...

>
> And I think my previous email still is relevant here...

... apparently not. I double checked the patch with 'checkpatch --strict'
and it does not detect any problem this time.

Sorry if I missed something obvious, I am quite new to this, but could
you give me some additional hint about the problem.