linux-kernel - Re: [PATCH v2] ceph: Fix file open flags on ppc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 17:23:46 +0800
From:   "Yan, Zheng" <zyan@...hat.com>
To:     Alexander Graf <agraf@...e.de>
Cc:     ceph-devel <ceph-devel@...r.kernel.org>,
        Sage Weil <sage@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jan.Fajerski@...e.com, Jeff Layton <jlayton@...hat.com>
Subject: Re: [PATCH v2] ceph: Fix file open flags on ppc64


> On 28 Apr 2017, at 17:14, Alexander Graf <agraf@...e.de> wrote:
> 
> 
> 
> On 28.04.17 09:57, Yan, Zheng wrote:
>> 
>>> On 28 Apr 2017, at 00:34, Alexander Graf <agraf@...e.de> wrote:
>>> 
>>> The file open flags (O_foo) are platform specific and should never go
>>> out to an interface that is not local to the system.
>>> 
>>> Unfortunately these flags have leaked out onto the wire in the cephfs
>>> implementation. That lead to bogus flags getting transmitted on ppc64.
>>> 
>>> This patch converts the kernel view of flags to the ceph view of file
>>> open flags.
>>> 
>>> Fixes: 124e68e74 ("ceph: file operations")
>>> Signed-off-by: Alexander Graf <agraf@...e.de>
>>> 
>>> —
>> 
>> I removed the "unused open flags” dout and applied the patch. Thank you for tracking down and fixing the bug.
> 
> I actually put that in on purpose, in case anyone in 2 years tries to find out why a particular flag doesn't get populated :).
> 
Ok, I will put it back.

Regards
Yan, Zheng

> 
> Alex