linux-kernel - Re: [PATCH] drivers:staging:wlan-ng:hfa384x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170428100258.GA4276@kroah.com>
Date:   Fri, 28 Apr 2017 12:02:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Karim Eshapa <karim.eshapa@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse
 warnings.

On Wed, Apr 26, 2017 at 06:15:40PM +0200, Karim Eshapa wrote:
> Fixing sparse warnings incorrect type assignment.
> 
> Signed-off-by: Karim Eshapa <karim.eshapa@...il.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
>  1 file changed, 14 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 6134eba..cf6bf65 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
>  		datap = skb_put(skb, sizeof(struct p80211_caphdr));
>  		caphdr = (struct p80211_caphdr *)datap;
>  
> -		caphdr->version = htonl(P80211CAPTURE_VERSION);
> -		caphdr->length = htonl(sizeof(struct p80211_caphdr));
> +		caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
> +		caphdr->length = __be32_to_cpu( htonl(sizeof(
> +						struct p80211_caphdr)));

How do you know this is correct?  And why the odd ' ' usage?  I can't
take this patch for that reason alone...

thanks,

greg k-h