linux-kernel - [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170424102858.GA1471@gmail.com>
Date:   Mon, 24 Apr 2017 11:28:58 +0100
From:   Andrea della Porta <sfaragnaus@...il.com>
To:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed
 sparse warning about different fmode_t type

Fixed the following sparse warning:

  CHECK   drivers/staging/lustre/lustre/llite//file.c
  drivers/staging/lustre/lustre/llite//file.c:441:24: warning: incorrect
  type in assignment (different base types)
  drivers/staging/lustre/lustre/llite//file.c:441:24:    expected
  restricted fmode_t [usertype] och_flags
  drivers/staging/lustre/lustre/llite//file.c:441:24:    got unsigned
  long long [unsigned] [usertype] it_flags
  drivers/staging/lustre/lustre/llite//file.c:465:65: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:465:22: warning: incorrect
  type in assignment (different base types)
  drivers/staging/lustre/lustre/llite//file.c:465:22:    expected
  restricted fmode_t [usertype] fd_omode
  drivers/staging/lustre/lustre/llite//file.c:465:22:    got unsigned
  long long
  drivers/staging/lustre/lustre/llite//file.c:526:38: warning: invalid
  assignment: |=
  drivers/staging/lustre/lustre/llite//file.c:526:38:    left side has
  type unsigned long long
  drivers/staging/lustre/lustre/llite//file.c:526:38:    right side has
  type restricted fmode_t
  drivers/staging/lustre/lustre/llite//file.c:533:49: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:553:28: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:556:35: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:778:23: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:1309:62: warning:
  restricted fmode_t degrades to integer
  drivers/staging/lustre/lustre/llite//file.c:1357:23: warning:
  incorrect type in initializer (different base types)
  drivers/staging/lustre/lustre/llite//file.c:1357:23:    expected
  unsigned long long [unsigned] [usertype] flags
  drivers/staging/lustre/lustre/llite//file.c:1357:23:    got restricted
  fmode_t [usertype] <noident>


Signed-off-by: Andrea della Porta <sfaragnaus@...il.com>
---
 drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_intent.h b/drivers/staging/lustre/lustre/include/lustre_intent.h
index ed2b6c6..c036633 100644
--- a/drivers/staging/lustre/lustre/include/lustre_intent.h
+++ b/drivers/staging/lustre/lustre/include/lustre_intent.h
@@ -38,7 +38,7 @@
 struct lookup_intent {
 	int		it_op;
 	int		it_create_mode;
-	__u64		it_flags;
+	fmode_t		it_flags;
 	int		it_disposition;
 	int		it_status;
 	__u64		it_lock_handle;
-- 
2.4.10