linux-kernel - Re: [PATCH] staging: rtl8192u: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 07:52:09 -0300
From:   Marcos Paulo de Souza <marcos.souza.org@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org,
        Elise Lennion <elise.lennion@...il.com>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Tobias Klauser <tklauser@...tanz.ch>,
        simran singhal <singhalsimran0@...il.com>,
        Bhumika Goyal <bhumirks@...il.com>
Subject: Re: [PATCH] staging: rtl8192u: Fix sparse warning

On Fri, Apr 28, 2017 at 12:29:55PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 23, 2017 at 05:51:17PM -0300, Marcos Paulo de Souza wrote:
> > Fix the following sparse warning:
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types)
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    expected restricted __le16 <noident>
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    got unsigned short [unsigned] [usertype] <noident>
> > 
> > Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type.
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
> > ---
> > 
> >  Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one!
> 
> Patch doesn't apply to my tree at all :(

My patch was based on master... my apologies. Will resend based on
staging-next.

-- 
Thanks,
	Marcos