linux-kernel - Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170428103347.GA7868@kroah.com>
Date:   Fri, 28 Apr 2017 12:33:47 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Lynn Lei <lynnl.jr@...look.com>
Cc:     "sudipm.mukherjee@...il.com" <sudipm.mukherjee@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "teddy.wang@...iconmotion.com" <teddy.wang@...iconmotion.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one
 statement

On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote:
> Combine two separate set GPIO(30 & 31) operations into one statement.

Why?

> 
> Signed-off-by: Lynn Lei <lynnl.jr@...look.com>
> ---
>  drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 68716ef7cb06..ddb7a6dc265a 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void)
>  
>  	/* Set GPIO 30 & 31 back as GPIO pins */
>  	value = peek32(GPIO_MUX);
> -	value &= ~GPIO_MUX_30;
> -	value &= ~GPIO_MUX_31;
> +	value &= ~(GPIO_MUX_30 | GPIO_MUX_31);

Why does this matter?

thanks,

greg k-h